Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Use param to set Bootstrap version in Contents page #35556

Merged
merged 1 commit into from
Dec 16, 2021
Merged

docs: Use param to set Bootstrap version in Contents page #35556

merged 1 commit into from
Dec 16, 2021

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Dec 16, 2021 •
edited

This PR proposes to use the docs_version param in the Getting Started > Contents documentation to avoid to forget update it after a change of version.

Note: could be done in the v4-dev branch as well if approved.

Preview: https://deploy-preview-35556--twbs-bootstrap.netlify.app/docs/5.1/getting-started/contents/#bootstrap-source-code

@julien-deramond julien-deramond mentioned this pull request Dec 16, 2021
Closed
ffoodd
ffoodd approved these changes Dec 16, 2021
View reviewed changes
Copy link
Member

@ffoodd ffoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, how did we miss that?
Thanks!

@XhmikosR
Copy link
Member

Because when I first made the switch to Hugo param wasn't even a thing 😛

Thanks!

@XhmikosR XhmikosR added this to In progress in v5.2.0 via automation Dec 16, 2021
@XhmikosR XhmikosR added this to In progress in v4.6.2 via automation Dec 16, 2021
@XhmikosR XhmikosR changed the title Use param to set Bootstrap version in Contents doc docs: Use param to set Bootstrap version in Contents page Dec 16, 2021
@XhmikosR XhmikosR merged commit 2d07383 into twbs:main Dec 16, 2021
v5.2.0 automation moved this from In progress to Done Dec 16, 2021
@julien-deramond julien-deramond deleted the main-jd-dynamic-version-in-contents branch December 16, 2021 08:21
@julien-deramond julien-deramond mentioned this pull request Dec 16, 2021
Merged
@XhmikosR XhmikosR removed this from In progress in v4.6.2 Dec 16, 2021
XhmikosR added a commit that referenced this pull request Dec 16, 2021
@julien-deramond @XhmikosR
Backport #35556 (#35558)
9c60983 
* Use param to set Bootstrap version in Contents doc

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
@RohitM-IN RohitM-IN mentioned this pull request May 19, 2024
Open
@humanbot humanbot mentioned this pull request May 20, 2024
Open
@saurabharch saurabharch mentioned this pull request May 20, 2024
Open
@h-gj h-gj mentioned this pull request May 21, 2024
Open
@RohitM-IN RohitM-IN mentioned this pull request May 22, 2024
Open
@jelenaCleo jelenaCleo mentioned this pull request May 22, 2024
Open
@snyk-io snyk-io bot mentioned this pull request May 23, 2024
Open
@Mhmonicox Mhmonicox mentioned this pull request May 24, 2024
Open
@RohitM-IN RohitM-IN mentioned this pull request May 24, 2024
Open
@jelenaCleo jelenaCleo mentioned this pull request May 24, 2024
Open
@ryanwittmers ryanwittmers mentioned this pull request May 24, 2024
Open
@jelenaCleo jelenaCleo mentioned this pull request May 25, 2024
Open
@RohitM-IN RohitM-IN mentioned this pull request May 25, 2024
Open
@angelika-draczynska angelika-draczynska mentioned this pull request May 26, 2024
Open
@ezelf86 ezelf86 mentioned this pull request May 26, 2024
Open
This was referenced May 27, 2024
Open
Open
Open
@ismaelgansonre ismaelgansonre mentioned this pull request May 29, 2024
Open
This was referenced May 30, 2024
Open
Open
Open
Open
Open
@Artur-data-DEV Artur-data-DEV mentioned this pull request Jun 4, 2024
Open
@RohitM-IN RohitM-IN mentioned this pull request Jun 4, 2024
Open
@jelenaCleo jelenaCleo mentioned this pull request Jun 5, 2024
Open
This was referenced Jun 5, 2024
Open
Open
@jelenaCleo jelenaCleo mentioned this pull request Jun 7, 2024
Open
@rfolkker rfolkker mentioned this pull request Jun 7, 2024
Open
@jelenaCleo jelenaCleo mentioned this pull request Jun 7, 2024
Open
@jin-mok jin-mok mentioned this pull request Jun 8, 2024
Open
This was referenced Jun 8, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ffoodd ffoodd ffoodd approved these changes

Assignees
No one assigned
Labels
backport-to-v4 docs v4 v5
Projects
No open projects
v5.2.0
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@julien-deramond @XhmikosR @ffoodd